ipykernel 7 support - take 2 #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
3 tasks
|
Awesome, thanks! |
|
Thanks. I'll re-enable the downstream tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #898 added support for
ipykernel7 on the basis that it was going to include the switch fromtornado/asynciotoanyio. That switch is no longer going to occur inipykernel7, so some of the changes made for it are no longer needed. Ipykernel 7 is now much closer to 6, the significant changes being experimental support for subshells (which do not have to be used) and use of a separate thread to manage the receipt and sending of shell channel messages.Here I have just removed the changes made in #898 that version checked
ipykernel >= 7. With this the tests pass for me locally on macOS usingipykernelmainbranch.